wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Draft: Small fixes (!505)


From: Avinash Sonawane (@rootkea)
Subject: Re: wget2 | Draft: Small fixes (!505)
Date: Thu, 23 Jun 2022 11:36:56 +0000



Avinash Sonawane commented on a discussion on unit-tests/test.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_1002613585

>       CHECK(!wget_memdup(NULL, 4));
>       CHECK(p = wget_memdup("xxx", 0)); xfree(p);
>       CHECK(p = wget_memdup("xxx", 4));
> -     CHECK(!memcmp(p, "xxx", 4)); xfree(p);
> +     if (p) {

Previously `scan-build make check` was 
[there](192df373ca9e14bbfb5648e8cee0418ca46dc682) but was latter 
[removed](c3075a1e218be7d23caddec966daa2305aef84bd). I guess it was an 
oversight? Or is there any particular reason for not having `scan-build make 
check`?

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_1002613585
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]