[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [platform-testers] new snapshot available: sed-

From: Jim Meyering
Subject: Re: [platform-testers] new snapshot available: sed-
Date: Thu, 8 Dec 2016 17:41:00 -0800

On Tue, Dec 6, 2016 at 5:10 PM, Assaf Gordon <address@hidden> wrote:
> Attached two changes:
>   maint: add missing fdl.texi to distribution
>   doc: follow-up changes for manual improvements
> This should work with texinfo 4.13 (also tested with 5.1 and 6.3).
> ===
> I noticed one other small problem:
> After a recent change which enabled some more warnings,
> compiling with gcc 5 (both 5.2.0 and 5.4.0) produces the following error:
>   sed/compile.c: In function 'savchar':
>   sed/compile.c:259:15: error: format '%x' expects argument of type 'unsigned 
> int',
>                                but argument 2   has type 'int' 
> [-Werror=format=]
>         panic("Called savchar() with unexpected pushback (%x)",
>               ^
> This warning is not triggered with gcc-4.9, and neither with gcc-6.2 or 
> gcc-7.0.
> And of course, it only happens when building from git, not from a tarball.
> The only distribution I know of that uses gcc-5.4 is Ubuntu 16.04 LTS.
> Debian 7 and 8, Ubuntu 14.04, SUSE and CentOS 6 and 7 use gcc-4.X,
> while Fedora 24 and 25 are already with gcc-6.
> So I'm not sure if this warrants a change.

I'm on the fence, too, but leaning towards feeling it's not worth a
change, since this strikes only those who bother to use
--enable-gcc-warnings on the losing systems.

Please push your two commits.

On top of those, I wrote the following to stop version-controlling the
generated sed.texi:

Attachment: sed-remove-sed.texi-from-vc.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]