[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 14/33] assertions for blockjob.h global state API
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v6 14/33] assertions for blockjob.h global state API |
Date: |
Fri, 21 Jan 2022 12:05:25 -0500 |
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
blockjob.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index 32fe27a6d4..cce8146cb6 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -62,6 +62,7 @@ static bool is_block_job(Job *job)
BlockJob *block_job_next(BlockJob *bjob)
{
Job *job = bjob ? &bjob->job : NULL;
+ assert(qemu_in_main_thread());
do {
job = job_next(job);
@@ -73,6 +74,7 @@ BlockJob *block_job_next(BlockJob *bjob)
BlockJob *block_job_get(const char *id)
{
Job *job = job_get(id);
+ assert(qemu_in_main_thread());
if (job && is_block_job(job)) {
return container_of(job, BlockJob, job);
@@ -184,6 +186,7 @@ static const BdrvChildClass child_job = {
void block_job_remove_all_bdrv(BlockJob *job)
{
+ assert(qemu_in_main_thread());
/*
* bdrv_root_unref_child() may reach child_job_[can_]set_aio_ctx(),
* which will also traverse job->nodes, so consume the list one by
@@ -206,6 +209,7 @@ void block_job_remove_all_bdrv(BlockJob *job)
bool block_job_has_bdrv(BlockJob *job, BlockDriverState *bs)
{
GSList *el;
+ assert(qemu_in_main_thread());
for (el = job->nodes; el; el = el->next) {
BdrvChild *c = el->data;
@@ -222,6 +226,7 @@ int block_job_add_bdrv(BlockJob *job, const char *name,
BlockDriverState *bs,
{
BdrvChild *c;
bool need_context_ops;
+ assert(qemu_in_main_thread());
bdrv_ref(bs);
@@ -271,6 +276,8 @@ bool block_job_set_speed(BlockJob *job, int64_t speed,
Error **errp)
const BlockJobDriver *drv = block_job_driver(job);
int64_t old_speed = job->speed;
+ assert(qemu_in_main_thread());
+
if (job_apply_verb(&job->job, JOB_VERB_SET_SPEED, errp) < 0) {
return false;
}
@@ -308,6 +315,8 @@ BlockJobInfo *block_job_query(BlockJob *job, Error **errp)
BlockJobInfo *info;
uint64_t progress_current, progress_total;
+ assert(qemu_in_main_thread());
+
if (block_job_is_internal(job)) {
error_setg(errp, "Cannot query QEMU internal jobs");
return NULL;
@@ -491,6 +500,7 @@ fail:
void block_job_iostatus_reset(BlockJob *job)
{
+ assert(qemu_in_main_thread());
if (job->iostatus == BLOCK_DEVICE_IO_STATUS_OK) {
return;
}
--
2.31.1
- Re: [PATCH v6 02/33] include/block/block: split header into I/O and global state API, (continued)
- [PATCH v6 06/33] block/block-backend.c: assertions for block-backend, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 05/33] include/sysemu/block-backend: split header into I/O and global state (GS) API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 08/33] assertions for block_int global state API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 10/33] include/block/blockjob_int.h: split header into I/O and GS API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 13/33] include/block/blockjob.h: global state API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 07/33] include/block/block_int: split header into I/O and global state API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 15/33] include/sysemu/blockdev.h: global state API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 12/33] block.c: add assertions to static functions, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 14/33] assertions for blockjob.h global state API,
Emanuele Giuseppe Esposito <=
- [PATCH v6 09/33] block: introduce assert_bdrv_graph_writable, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 11/33] assertions for blockjob_int.h, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 29/33] job.h: assertions in the callers of JobDriver funcion pointers, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 18/33] block/copy-before-write.h: global state API + assertions, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 24/33] block_int-common.h: assertions in the callers of BlockDriver function pointers, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 16/33] assertions for blockdev.h global state API, Emanuele Giuseppe Esposito, 2022/01/21
- [PATCH v6 23/33] block_int-common.h: split function pointers in BlockDriver, Emanuele Giuseppe Esposito, 2022/01/21