Re: [PATCH v6 06/33] block/block-backend.c: assertions for block-backend

[Hanna Reitz]

On 21.01.22 18:05, Emanuele Giuseppe Esposito wrote:
> All the global state (GS) API functions will check that
> qemu_in_main_thread() returns true. If not, it means
> that the safety of BQL cannot be guaranteed, and
> they need to be moved to I/O.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
>   block/block-backend.c  | 79 ++++++++++++++++++++++++++++++++++++++++++
>   softmmu/qdev-monitor.c |  2 ++
>   2 files changed, 81 insertions(+)
>
> diff --git a/block/block-backend.c b/block/block-backend.c
> index 6f91dcc85d..6c80ae54cc 100644
> --- a/block/block-backend.c
> +++ b/block/block-backend.c

[...]

> @@ -1908,6 +1958,7 @@ void blk_lock_medium(BlockBackend *blk, bool locked)
>   void blk_eject(BlockBackend *blk, bool eject_flag)
>   {
>       BlockDriverState *bs = blk_bs(blk);
> +
>       char *id;
>   
>       if (bs) {

Left over hunk from when when there was an assertion added here, should 
be dropped, I believe.

Hanna