qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 29/33] job.h: assertions in the callers of JobDriver funci


From: Hanna Reitz
Subject: Re: [PATCH v6 29/33] job.h: assertions in the callers of JobDriver funcion pointers
Date: Wed, 26 Jan 2022 15:13:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 21.01.22 18:05, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
  job.c | 9 +++++++++
  1 file changed, 9 insertions(+)

Just curious, why did you remove the assertion in job_co_entry()? (Looking at it again, it might have been nicer to swap it with the assertion below it, so that `job != NULL` is asserted first, but other than that...)

(And since I’m already replying to this patch, might as well point out s/funcion/function/ in the subject)

Hanna




reply via email to

[Prev in Thread] Current Thread [Next in Thread]