Re: [PATCH v6 29/33] job.h: assertions in the callers of JobDriver funcion pointers

[Emanuele Giuseppe Esposito]

On 26/01/2022 15:13, Hanna Reitz wrote:
> On 21.01.22 18:05, Emanuele Giuseppe Esposito wrote:
>> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
>> ---
>>   job.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
> 
> Just curious, why did you remove the assertion in job_co_entry()?
> (Looking at it again, it might have been nicer to swap it with the
> assertion below it, so that `job != NULL` is asserted first, but other
> than that...)
> 
I think it's useless, job_co_entry runs in a coroutine in
job->aio_context created and entered in job_start (its only caller), so
there is no way that we are in a different aiocontext.

Same as assert(job), I don't think the opaque pointer can ever be NULL.

Thank you,
Emanuele

> (And since I’m already replying to this patch, might as well point out
> s/funcion/function/ in the subject)
> 
> Hanna
>