Re: [PATCH 06/10] rust: pl011: extract PL011Registers

[Paolo Bonzini]

Il gio 23 gen 2025, 04:25 Zhao Liu <zhao1.liu@intel.com> ha scritto:

> --- a/rust/hw/char/pl011/src/device_class.rs
> +++ b/rust/hw/char/pl011/src/device_class.rs
> @@ -6,11 +6,11 @@
>  use std::os::raw::{c_int, c_void};
> 
>  use qemu_api::{
> -    bindings::*, c_str, vmstate_clock, vmstate_fields, vmstate_of, vmstate_subsections,
> -    vmstate_unused, zeroable::Zeroable,
> +    bindings::*, c_str, vmstate_clock, vmstate_fields, vmstate_of, vmstate_struct,

Oops, I forgot to clean up this bindings::*.

No big deal (it's a secondary file and will probably be merged into device.rs as soon as VMState bindings are more complete).

Paolo

> +    vmstate_subsections, vmstate_unused, zeroable::Zeroable,
>  };
> 

Very good example!

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>