[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] rust: pl011: extract PL011Registers
From: |
Zhao Liu |
Subject: |
Re: [PATCH 06/10] rust: pl011: extract PL011Registers |
Date: |
Thu, 23 Jan 2025 11:44:28 +0800 |
> --- a/rust/hw/char/pl011/src/device_class.rs
> +++ b/rust/hw/char/pl011/src/device_class.rs
> @@ -6,11 +6,11 @@
> use std::os::raw::{c_int, c_void};
>
> use qemu_api::{
> - bindings::*, c_str, vmstate_clock, vmstate_fields, vmstate_of,
> vmstate_subsections,
> - vmstate_unused, zeroable::Zeroable,
> + bindings::*, c_str, vmstate_clock, vmstate_fields, vmstate_of,
> vmstate_struct,
Oops, I forgot to clean up this bindings::*.
> + vmstate_subsections, vmstate_unused, zeroable::Zeroable,
> };
>
Very good example!
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
- [PATCH 02/10] rust: pl011: hide unnecessarily "pub" items from outside pl011::device, (continued)
- [PATCH 04/10] rust: pl011: extract CharBackend receive logic into a separate function, Paolo Bonzini, 2025/01/17
- [PATCH 06/10] rust: pl011: extract PL011Registers, Paolo Bonzini, 2025/01/17
- Re: [PATCH 06/10] rust: pl011: extract PL011Registers,
Zhao Liu <=
- [PATCH 05/10] rust: pl011: pull interrupt updates out of read/write ops, Paolo Bonzini, 2025/01/17
- [PATCH 07/10] rust: pl011: wrap registers with BqlRefCell, Paolo Bonzini, 2025/01/17
[PATCH 10/10] rust: qdev: make reset take a shared reference, Paolo Bonzini, 2025/01/17