[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/10] rust: pl011: hide unnecessarily "pub" items from outsi
From: |
Zhao Liu |
Subject: |
Re: [PATCH 02/10] rust: pl011: hide unnecessarily "pub" items from outside pl011::device |
Date: |
Wed, 22 Jan 2025 21:39:03 +0800 |
On Fri, Jan 17, 2025 at 10:26:49AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:49 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 02/10] rust: pl011: hide unnecessarily "pub" items from
> outside pl011::device
> X-Mailer: git-send-email 2.47.1
>
> The only public interfaces for pl011 are TYPE_PL011 and pl011_create.
> Remove pub from everything else.
>
> Note: the "allow(dead_code)" is removed later.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/char/pl011/src/device.rs | 2 +-
> rust/hw/char/pl011/src/device_class.rs | 2 +-
> rust/hw/char/pl011/src/lib.rs | 13 ++++++++-----
> 3 files changed, 10 insertions(+), 7 deletions(-)
>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>