qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/10] rust: pl011: extract CharBackend receive logic into a


From: Paolo Bonzini
Subject: Re: [PATCH 04/10] rust: pl011: extract CharBackend receive logic into a separate function
Date: Wed, 22 Jan 2025 16:04:55 +0100
User-agent: Mozilla Thunderbird

On 1/22/25 15:59, Zhao Liu wrote:
          if size > 0 {
              debug_assert!(!buf.is_null());
-            state.as_mut().put_fifo(c_uint::from(buf.read_volatile()))

An extra question...here I'm not sure, do we really need read_volatile?

No, the buffer is not guest visible. It will certainly go away together with chardev bindings.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]