Re: [PATCH v5 0/3] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files

[Ani Sinha]

On Fri, Jan 10, 2025 at 4:16 PM Ani Sinha <anisinha@redhat.com> wrote:
>
> This patchset enables DMA interface support for writing fw-cfg files in
> libqtest. The first patch is just a code refactoring so that fw-cfg
> directory parsing can be part of a separate helper function.
> The second patch is the actual patch that introduces two new apis for
> writing and reading fw-cfg files using DMA interface. The apis are
> tested by writing a new basic qtest for vmcoreinfo device in patch 3.
>
> $ MALLOC_PERTURB_=255  QTEST_QEMU_BINARY=./qemu-system-x86_64  
> /workspace/qemu-ani/build/tests/qtest/vmcoreinfo-test
> TAP version 13
> # random seed: R02S33ea0ae4568aae69a6191a97e6ea37fc
> 1..1
> # Start of x86_64 tests
> # Start of vmcoreinfo tests
> # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-267380.sock 
> -qtest-log /dev/null -chardev socket,path=/tmp/qtest-267380.qmp,id=char0 -mon 
> chardev=char0,mode=control -display none -audio none -device vmcoreinfo 
> -accel qtest
> ok 1 /x86_64/vmcoreinfo/basic-write
> # End of vmcoreinfo tests
> # End of x86_64 tests

CI pipeline seems green when run on this patch series:
https://gitlab.com/anisinha/qemu/-/pipelines/1629670893
(one failure seems unrelated)

>
> cc: kraxel@redhat.com
> cc: farosas@suse.de
> cc: lvivier@redhat.com
> cc: pbonzini@redhat.com
> cc: armbru@redhat.com
> cc: philmd@linaro.org
> cc: berrange@redhat.com
> cc: qemu-devel@nongnu.org
> cc: farosas@suse.de
>
> changelog:
> v3: first working version of the patch.
> v4: refactoring without any new changes put into a new patch.
> v5: a new qtest added to exercize the two new write and read apis.
>
> all along, other review feedbacks has been taken into account.
>
> Ani Sinha (3):
>   libqos/fw_cfg: refactor file directory iteraton to make it more
>     reusable
>   tests/qtest/libqos: add DMA support for writing and reading fw_cfg
>     files
>   tests/qtest/vmcoreinfo: add a unit test to exercize basic vmcoreinfo
>     function
>
>  MAINTAINERS                   |   2 +
>  tests/qtest/libqos/fw_cfg.c   | 204 ++++++++++++++++++++++++++++++----
>  tests/qtest/libqos/fw_cfg.h   |   6 +-
>  tests/qtest/meson.build       |   1 +
>  tests/qtest/vmcoreinfo-test.c |  90 +++++++++++++++
>  5 files changed, 280 insertions(+), 23 deletions(-)
>  create mode 100644 tests/qtest/vmcoreinfo-test.c
>
> --
> 2.45.2
>