Re: [PATCH v5 1/3] libqos/fw_cfg: refactor file directory iteraton to make it more reusable

[Ani Sinha]

On Fri, Jan 10, 2025 at 9:48 PM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> On 10/1/25 11:46, Ani Sinha wrote:
> > fw-cfg file directory iteration code can be used by other functions that may
> > want to implement fw-cfg file operations. Refactor it into a smaller helper
> > so that it can be reused.
> >
> > No functional change.
> >
> > Signed-off-by: Ani Sinha <anisinha@redhat.com>
> > ---
> >   tests/qtest/libqos/fw_cfg.c | 62 ++++++++++++++++++++++++-------------
> >   1 file changed, 40 insertions(+), 22 deletions(-)
> >
> > diff --git a/tests/qtest/libqos/fw_cfg.c b/tests/qtest/libqos/fw_cfg.c
> > index 89f053ccac..b178d0b1b8 100644
> > --- a/tests/qtest/libqos/fw_cfg.c
> > +++ b/tests/qtest/libqos/fw_cfg.c
> > @@ -60,6 +60,38 @@ static void mm_fw_cfg_select(QFWCFG *fw_cfg, uint16_t 
> > key)
> >       qtest_writew(fw_cfg->qts, fw_cfg->base, key);
> >   }
> >
> > +static bool
> > +find_pdir_entry(QFWCFG *fw_cfg, const char *filename,
> > +                uint16_t *sel, uint32_t *size)
>
> Please use QEMU coding style.

btw, checkpatch did not catch this. I suggest we also fix checkpatch


$ ./scripts/checkpatch.pl patches-v5/*
Checking 
patches-v5/0001-libqos-fw_cfg-refactor-file-directory-iteraton-to-ma.patch...
total: 0 errors, 0 warnings, 78 lines checked
patches-v5/0001-libqos-fw_cfg-refactor-file-directory-iteraton-to-ma.patch
has no obvious style problems and is ready for submission.

Checking 
patches-v5/0002-tests-qtest-libqos-add-DMA-support-for-writing-and-r.patch...
total: 0 errors, 0 warnings, 178 lines checked
patches-v5/0002-tests-qtest-libqos-add-DMA-support-for-writing-and-r.patch
has no obvious style problems and is ready for submission.

Checking 
patches-v5/0003-tests-qtest-vmcoreinfo-add-a-unit-test-to-exercize-b.patch...
total: 0 errors, 0 warnings, 111 lines checked
patches-v5/0003-tests-qtest-vmcoreinfo-add-a-unit-test-to-exercize-b.patch
has no obvious style problems and is ready for submission.