qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/3] libqos/fw_cfg: refactor file directory iteraton to ma


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 1/3] libqos/fw_cfg: refactor file directory iteraton to make it more reusable
Date: Fri, 10 Jan 2025 17:18:17 +0100
User-agent: Mozilla Thunderbird

On 10/1/25 11:46, Ani Sinha wrote:
fw-cfg file directory iteration code can be used by other functions that may
want to implement fw-cfg file operations. Refactor it into a smaller helper
so that it can be reused.

No functional change.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
  tests/qtest/libqos/fw_cfg.c | 62 ++++++++++++++++++++++++-------------
  1 file changed, 40 insertions(+), 22 deletions(-)

diff --git a/tests/qtest/libqos/fw_cfg.c b/tests/qtest/libqos/fw_cfg.c
index 89f053ccac..b178d0b1b8 100644
--- a/tests/qtest/libqos/fw_cfg.c
+++ b/tests/qtest/libqos/fw_cfg.c
@@ -60,6 +60,38 @@ static void mm_fw_cfg_select(QFWCFG *fw_cfg, uint16_t key)
      qtest_writew(fw_cfg->qts, fw_cfg->base, key);
  }
+static bool
+find_pdir_entry(QFWCFG *fw_cfg, const char *filename,
+                uint16_t *sel, uint32_t *size)

Please use QEMU coding style.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]