Re: [PATCH] rust: add --check-cfg test to rustc arguments

[Paolo Bonzini]

On Fri, Jan 17, 2025 at 5:01 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > rustc will check that every reachable #[cfg] matches a list of
> > the expected config names and values.  Recent versions of rustc are
> > also complaining about #[cfg(test)], even if it is basically a standard
> > part of the language.  So, always allow it.
>
> Hmm this breaks the non-project CI builds even further (I as hoping it
> would help):

You hoped right; the patch has a typo (sorry about that) and needs to
print 'cfg(test)'. The correct patch is included in my latest pull
request.

Do not worry too much about failures in the nightly Rust job unless
you're working on Rust itself; it's there so that future breakage is
detected early, as in this case of a compiler change that had a
matching cargo change.

Paolo