[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/15] target/riscv/vector_helper.c: optimize loops in ldst helper
From: |
Alistair Francis |
Subject: |
[PULL 11/15] target/riscv/vector_helper.c: optimize loops in ldst helpers |
Date: |
Fri, 22 Mar 2024 18:53:15 +1000 |
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Change the for loops in ldst helpers to do a single increment in the
counter, and assign it env->vstart, to avoid re-reading from vstart
every time.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20240314175704.478276-11-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
target/riscv/vector_helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index 63a1083f03..fa139040f8 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -209,7 +209,7 @@ vext_ldst_stride(void *vd, void *v0, target_ulong base,
VSTART_CHECK_EARLY_EXIT(env);
- for (i = env->vstart; i < env->vl; i++, env->vstart++) {
+ for (i = env->vstart; i < env->vl; env->vstart = ++i) {
k = 0;
while (k < nf) {
if (!vm && !vext_elem_mask(v0, i)) {
@@ -277,7 +277,7 @@ vext_ldst_us(void *vd, target_ulong base, CPURISCVState
*env, uint32_t desc,
VSTART_CHECK_EARLY_EXIT(env);
/* load bytes from guest memory */
- for (i = env->vstart; i < evl; i++, env->vstart++) {
+ for (i = env->vstart; i < evl; env->vstart = ++i) {
k = 0;
while (k < nf) {
target_ulong addr = base + ((i * nf + k) << log2_esz);
@@ -393,7 +393,7 @@ vext_ldst_index(void *vd, void *v0, target_ulong base,
VSTART_CHECK_EARLY_EXIT(env);
/* load bytes from guest memory */
- for (i = env->vstart; i < env->vl; i++, env->vstart++) {
+ for (i = env->vstart; i < env->vl; env->vstart = ++i) {
k = 0;
while (k < nf) {
if (!vm && !vext_elem_mask(v0, i)) {
--
2.44.0
- [PULL 02/15] target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX(), (continued)
- [PULL 02/15] target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX(), Alistair Francis, 2024/03/22
- [PULL 03/15] trans_rvv.c.inc: set vstart = 0 in int scalar move insns, Alistair Francis, 2024/03/22
- [PULL 04/15] target/riscv/vector_helper.c: fix 'vmvr_v' memcpy endianess, Alistair Francis, 2024/03/22
- [PULL 07/15] target/riscv/vector_helpers: do early exit when vstart >= vl, Alistair Francis, 2024/03/22
- [PULL 09/15] trans_rvv.c.inc: remove redundant mark_vs_dirty() calls, Alistair Francis, 2024/03/22
- [PULL 12/15] hw/intc: Update APLIC IDC after claiming iforce register, Alistair Francis, 2024/03/22
- [PULL 13/15] target/riscv: rvv: Remove the dependency of Zvfbfmin to Zfbfmin, Alistair Francis, 2024/03/22
- [PULL 14/15] target/riscv: Fix mode in riscv_tlb_fill, Alistair Francis, 2024/03/22
- [PULL 15/15] target/riscv/kvm: fix timebase-frequency when using KVM acceleration, Alistair Francis, 2024/03/22
- [PULL 01/15] target/riscv: do not enable all named features by default, Alistair Francis, 2024/03/22
- [PULL 11/15] target/riscv/vector_helper.c: optimize loops in ldst helpers,
Alistair Francis <=
- [PULL 10/15] target/riscv: enable 'vstart_eq_zero' in the end of insns, Alistair Francis, 2024/03/22
- [PULL 05/15] target/riscv: always clear vstart in whole vec move insns, Alistair Francis, 2024/03/22
- [PULL 08/15] target/riscv: remove 'over' brconds from vector trans, Alistair Francis, 2024/03/22
- [PULL 06/15] target/riscv: always clear vstart for ldst_whole insns, Alistair Francis, 2024/03/22
- Re: [PULL 00/15] riscv-to-apply queue, Peter Maydell, 2024/03/22
- Re: [PULL 00/15] riscv-to-apply queue, Michael Tokarev, 2024/03/22