[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/15] target/riscv/vector_helper.c: fix 'vmvr_v' memcpy endianess
From: |
Alistair Francis |
Subject: |
[PULL 04/15] target/riscv/vector_helper.c: fix 'vmvr_v' memcpy endianess |
Date: |
Fri, 22 Mar 2024 18:53:08 +1000 |
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
vmvr_v isn't handling the case where the host might be big endian and
the bytes to be copied aren't sequential.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Fixes: f714361ed7 ("target/riscv: rvv-1.0: implement vstart CSR")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20240314175704.478276-4-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
target/riscv/vector_helper.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index ca79571ae2..34ac4aa808 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -5075,9 +5075,17 @@ void HELPER(vmvr_v)(void *vd, void *vs2, CPURISCVState
*env, uint32_t desc)
uint32_t startb = env->vstart * sewb;
uint32_t i = startb;
+ if (HOST_BIG_ENDIAN && i % 8 != 0) {
+ uint32_t j = ROUND_UP(i, 8);
+ memcpy((uint8_t *)vd + H1(j - 1),
+ (uint8_t *)vs2 + H1(j - 1),
+ j - i);
+ i = j;
+ }
+
memcpy((uint8_t *)vd + H1(i),
(uint8_t *)vs2 + H1(i),
- maxsz - startb);
+ maxsz - i);
env->vstart = 0;
}
--
2.44.0
- [PULL 00/15] riscv-to-apply queue, Alistair Francis, 2024/03/22
- [PULL 02/15] target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX(), Alistair Francis, 2024/03/22
- [PULL 03/15] trans_rvv.c.inc: set vstart = 0 in int scalar move insns, Alistair Francis, 2024/03/22
- [PULL 04/15] target/riscv/vector_helper.c: fix 'vmvr_v' memcpy endianess,
Alistair Francis <=
- [PULL 07/15] target/riscv/vector_helpers: do early exit when vstart >= vl, Alistair Francis, 2024/03/22
- [PULL 09/15] trans_rvv.c.inc: remove redundant mark_vs_dirty() calls, Alistair Francis, 2024/03/22
- [PULL 12/15] hw/intc: Update APLIC IDC after claiming iforce register, Alistair Francis, 2024/03/22
- [PULL 13/15] target/riscv: rvv: Remove the dependency of Zvfbfmin to Zfbfmin, Alistair Francis, 2024/03/22
- [PULL 14/15] target/riscv: Fix mode in riscv_tlb_fill, Alistair Francis, 2024/03/22
- [PULL 15/15] target/riscv/kvm: fix timebase-frequency when using KVM acceleration, Alistair Francis, 2024/03/22
- [PULL 01/15] target/riscv: do not enable all named features by default, Alistair Francis, 2024/03/22
- [PULL 11/15] target/riscv/vector_helper.c: optimize loops in ldst helpers, Alistair Francis, 2024/03/22
- [PULL 10/15] target/riscv: enable 'vstart_eq_zero' in the end of insns, Alistair Francis, 2024/03/22
- [PULL 05/15] target/riscv: always clear vstart in whole vec move insns, Alistair Francis, 2024/03/22