[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for 9.0 v15 10/10] target/riscv/vector_helper.c: optimize loops i
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH for 9.0 v15 10/10] target/riscv/vector_helper.c: optimize loops in ldst helpers |
Date: |
Thu, 14 Mar 2024 14:57:04 -0300 |
Change the for loops in ldst helpers to do a single increment in the
counter, and assign it env->vstart, to avoid re-reading from vstart
every time.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/riscv/vector_helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index 63a1083f03..fa139040f8 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -209,7 +209,7 @@ vext_ldst_stride(void *vd, void *v0, target_ulong base,
VSTART_CHECK_EARLY_EXIT(env);
- for (i = env->vstart; i < env->vl; i++, env->vstart++) {
+ for (i = env->vstart; i < env->vl; env->vstart = ++i) {
k = 0;
while (k < nf) {
if (!vm && !vext_elem_mask(v0, i)) {
@@ -277,7 +277,7 @@ vext_ldst_us(void *vd, target_ulong base, CPURISCVState
*env, uint32_t desc,
VSTART_CHECK_EARLY_EXIT(env);
/* load bytes from guest memory */
- for (i = env->vstart; i < evl; i++, env->vstart++) {
+ for (i = env->vstart; i < evl; env->vstart = ++i) {
k = 0;
while (k < nf) {
target_ulong addr = base + ((i * nf + k) << log2_esz);
@@ -393,7 +393,7 @@ vext_ldst_index(void *vd, void *v0, target_ulong base,
VSTART_CHECK_EARLY_EXIT(env);
/* load bytes from guest memory */
- for (i = env->vstart; i < env->vl; i++, env->vstart++) {
+ for (i = env->vstart; i < env->vl; env->vstart = ++i) {
k = 0;
while (k < nf) {
if (!vm && !vext_elem_mask(v0, i)) {
--
2.44.0
- Re: [PATCH for 9.0 v15 05/10] target/riscv: always clear vstart for ldst_whole insns, (continued)
- [PATCH for 9.0 v15 04/10] target/riscv: always clear vstart in whole vec move insns, Daniel Henrique Barboza, 2024/03/14
- [PATCH for 9.0 v15 06/10] target/riscv/vector_helpers: do early exit when vstart >= vl, Daniel Henrique Barboza, 2024/03/14
- [PATCH for 9.0 v15 07/10] target/riscv: remove 'over' brconds from vector trans, Daniel Henrique Barboza, 2024/03/14
- [PATCH for 9.0 v15 08/10] trans_rvv.c.inc: remove redundant mark_vs_dirty() calls, Daniel Henrique Barboza, 2024/03/14
- [PATCH for 9.0 v15 09/10] target/riscv: enable 'vstart_eq_zero' in the end of insns, Daniel Henrique Barboza, 2024/03/14
- [PATCH for 9.0 v15 10/10] target/riscv/vector_helper.c: optimize loops in ldst helpers,
Daniel Henrique Barboza <=
- Re: [PATCH for 9.0 v15 00/10] target/riscv: vector fixes, Alistair Francis, 2024/03/20