Re: [PULL 00/15] riscv-to-apply queue

[Daniel Henrique Barboza]

On 3/24/24 12:07, Michael Tokarev wrote:
> 22.03.2024 22:46, Daniel Henrique Barboza :
> > On 3/22/24 14:16, Michael Tokarev wrote:
> > > 22.03.2024 11:53, Alistair Francis :
> > >
> > > > RISC-V PR for 9.0
> > > >
> > > > * Do not enable all named features by default
> > > > * A range of Vector fixes
> > > > * Update APLIC IDC after claiming iforce register
> > > > * Remove the dependency of Zvfbfmin to Zfbfmin
> > > > * Fix mode in riscv_tlb_fill
> > > > * Fix timebase-frequency when using KVM acceleration
> > >
> > > Should something from there be picked up for stable (8.2 and probably 7.2)?
> >
> > Ignore the "Do not enable all named features by default" since it's fixing 
> > something
> > that were added in 9.0.
> >
> > The rest you can pick it up to 8.2 at least. Thanks,
>
> Unfortunately this doesn't quite work, the following changes
> fail to apply to 8.2:
>
> 929e521a47 target/riscv: always clear vstart for ldst_whole insns
> b46631f122 target/riscv: remove 'over' brconds from vector trans
> d57dfe4b37 trans_rvv.c.inc: remove redundant mark_vs_dirty() calls
> bac802ada8 target/riscv: enable 'vstart_eq_zero' in the end of insns
> 385e575cd5 target/riscv/kvm: fix timebase-frequency when using KVM acceleration
>
> I tried to back-port at least the first one but it turned out to be
> another failure.  Didn't try looking at the rest.

This particular code (vector emulation) has been going through a lot of
changes in the last couple of releases, so I'm not surprised with the
difficulty with backporting these.

> If these really should be in 8.2 (it's your guys to decide, not me),
> I need help with back-porting these to 8.2 (and/or cherry-picking
> additional patches from master).

The amount of work can be non-trivial for this backport, so I'd say we should
leave it aside for now. If someone has a good argument for this work then we
can re-evaluate.


Thanks,

Daniel

> Thanks,
>
> /mjt
>
> > > > ----------------------------------------------------------------
> > > > Daniel Henrique Barboza (10):
> > > >        target/riscv: do not enable all named features by default
> > > >        target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX()
> > > >        trans_rvv.c.inc: set vstart = 0 in int scalar move insns
> > > >        target/riscv/vector_helper.c: fix 'vmvr_v' memcpy endianess
> > > >        target/riscv: always clear vstart in whole vec move insns
> > > >        target/riscv: always clear vstart for ldst_whole insns
> > > >        target/riscv/vector_helpers: do early exit when vstart >= vl
> > > >        target/riscv: remove 'over' brconds from vector trans
> > > >        trans_rvv.c.inc: remove redundant mark_vs_dirty() calls
> > > >        target/riscv/vector_helper.c: optimize loops in ldst helpers
> > > >
> > > > Frank Chang (1):
> > > >        hw/intc: Update APLIC IDC after claiming iforce register
> > > >
> > > > Irina Ryapolova (1):
> > > >        target/riscv: Fix mode in riscv_tlb_fill
> > > >
> > > > Ivan Klokov (1):
> > > >        target/riscv: enable 'vstart_eq_zero' in the end of insns
> > > >
> > > > Max Chou (1):
> > > >        target/riscv: rvv: Remove the dependency of Zvfbfmin to Zfbfmin
> > > >
> > > > Yong-Xuan Wang (1):
> > > >        target/riscv/kvm: fix timebase-frequency when using KVM acceleration