[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 15/22] parallels: Handle L1 entries equal to one
From: |
Alexander Ivanov |
Subject: |
[PATCH v5 15/22] parallels: Handle L1 entries equal to one |
Date: |
Mon, 11 Mar 2024 19:18:43 +0100 |
If all the bits in a dirty bitmap cluster are ones, the cluster shouldn't
be written. Instead the corresponding L1 entry should be set to 1.
Check if all bits in a memory region are ones and set 1 to L1 entries
corresponding clusters filled with ones.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels-ext.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/block/parallels-ext.c b/block/parallels-ext.c
index 1ec23aa1e7..67fa3b73c2 100644
--- a/block/parallels-ext.c
+++ b/block/parallels-ext.c
@@ -383,7 +383,7 @@ static void GRAPH_RDLOCK
parallels_save_bitmap(BlockDriverState *bs,
offset = 0;
while ((offset = bdrv_dirty_bitmap_next_dirty(bitmap, offset, bm_size)) >=
0) {
idx = offset / bits_per_cluster;
- int64_t cluster_off, end, write_size;
+ int64_t cluster_off, end, write_size, first_zero;
offset = QEMU_ALIGN_DOWN(offset, bits_per_cluster);
end = MIN(bm_size, offset + bits_per_cluster);
@@ -398,6 +398,16 @@ static void GRAPH_RDLOCK
parallels_save_bitmap(BlockDriverState *bs,
l1_table[idx] = 0;
+ first_zero = bdrv_dirty_bitmap_next_zero(bitmap, offset, bm_size);
+ if (first_zero < 0) {
+ goto clean_allocated_clusters;
+ }
+ if (first_zero - offset >= s->cluster_size) {
+ l1_table[idx] = 1;
+ offset = end;
+ continue;
+ }
+
cluster_off = parallels_allocate_host_clusters(bs, &alloc_size);
if (cluster_off <= 0) {
error_report("Can't save dirty bitmap '%s': cluster allocation
error",
--
2.40.1
- [PATCH v5 00/22] parallels: Add full dirty bitmap support, Alexander Ivanov, 2024/03/11
- [PATCH v5 02/22] parallels: Move inactivation code to a separate function, Alexander Ivanov, 2024/03/11
- [PATCH v5 03/22] parallels: Make mark_used() a global function, Alexander Ivanov, 2024/03/11
- [PATCH v5 07/22] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2024/03/11
- [PATCH v5 20/22] tests: Add parallels images support to test 165, Alexander Ivanov, 2024/03/11
- [PATCH v5 21/22] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2024/03/11
- [PATCH v5 01/22] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2024/03/11
- [PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed, Alexander Ivanov, 2024/03/11
- [PATCH v5 15/22] parallels: Handle L1 entries equal to one,
Alexander Ivanov <=
- [PATCH v5 14/22] parallels: Preserve extensions cluster for non-transient extensions, Alexander Ivanov, 2024/03/11
- [PATCH v5 08/22] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 18/22] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 09/22] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2024/03/11
- [PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the last marked claster, Alexander Ivanov, 2024/03/11
- [PATCH v5 13/22] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2024/03/11
- [PATCH v5 16/22] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2024/03/11
- [PATCH v5 06/22] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2024/03/11
- [PATCH v5 11/22] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2024/03/11
- [PATCH v5 22/22] tests: Add parallels format support to image-fleecing, Alexander Ivanov, 2024/03/11