[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the l
From: |
Alexander Ivanov |
Subject: |
[PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the last marked claster |
Date: |
Mon, 11 Mar 2024 19:18:32 +0100 |
There is no necessity to search to the end of the bitmap. Limit the search
area as cluster_index + count.
Add cluster_end variable to avoid its calculation in a few places.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
block/parallels.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index ae524f1820..4470519656 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -182,13 +182,14 @@ int parallels_mark_used(BlockDriverState *bs, unsigned
long *bitmap,
uint32_t bitmap_size, int64_t off, uint32_t count)
{
BDRVParallelsState *s = bs->opaque;
- uint32_t cluster_index = host_cluster_index(s, off);
+ uint32_t cluster_end, cluster_index = host_cluster_index(s, off);
unsigned long next_used;
- if (cluster_index + count > bitmap_size) {
+ cluster_end = cluster_index + count;
+ if (cluster_end > bitmap_size) {
return -E2BIG;
}
- next_used = find_next_bit(bitmap, bitmap_size, cluster_index);
- if (next_used < cluster_index + count) {
+ next_used = find_next_bit(bitmap, cluster_end, cluster_index);
+ if (next_used < cluster_end) {
return -EBUSY;
}
bitmap_set(bitmap, cluster_index, count);
--
2.40.1
- [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper, (continued)
- [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2024/03/11
- [PATCH v5 20/22] tests: Add parallels images support to test 165, Alexander Ivanov, 2024/03/11
- [PATCH v5 21/22] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2024/03/11
- [PATCH v5 01/22] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2024/03/11
- [PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed, Alexander Ivanov, 2024/03/11
- [PATCH v5 15/22] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2024/03/11
- [PATCH v5 14/22] parallels: Preserve extensions cluster for non-transient extensions, Alexander Ivanov, 2024/03/11
- [PATCH v5 08/22] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 18/22] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 09/22] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2024/03/11
- [PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the last marked claster,
Alexander Ivanov <=
- [PATCH v5 13/22] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2024/03/11
- [PATCH v5 16/22] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2024/03/11
- [PATCH v5 06/22] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2024/03/11
- [PATCH v5 11/22] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2024/03/11
- [PATCH v5 22/22] tests: Add parallels format support to image-fleecing, Alexander Ivanov, 2024/03/11
- [PATCH v5 10/22] parallels: Create used bitmap even if checks needed, Alexander Ivanov, 2024/03/11
- [PATCH v5 17/22] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2024/03/11
- [PATCH v5 19/22] parallels: Remove unnecessary data_end field, Alexander Ivanov, 2024/03/11