[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not
From: |
Alexander Ivanov |
Subject: |
[PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed |
Date: |
Mon, 11 Mar 2024 19:18:40 +0100 |
From: "Denis V. Lunev" <den@openvz.org>
This data is obsolete.
The approach is exactly the same like we use with QCOW2.
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
block/parallels-ext.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/block/parallels-ext.c b/block/parallels-ext.c
index 9cb8e65c0d..7fa14b057d 100644
--- a/block/parallels-ext.c
+++ b/block/parallels-ext.c
@@ -255,6 +255,14 @@ parallels_parse_format_extension(BlockDriverState *bs,
uint8_t *ext_cluster,
return 0;
case PARALLELS_DIRTY_BITMAP_FEATURE_MAGIC:
+ if (s->header_unclean) {
+ /*
+ * The image was not closed correctly and thus dirty bitmap
+ * data inside the image is considered as incorrect and thus
+ * it should be dropper, exactly like we do for QCOW2.
+ */
+ break;
+ }
bitmap = parallels_load_bitmap(bs, pos, fh.data_size, errp);
if (!bitmap) {
goto fail;
--
2.40.1
- [PATCH v5 00/22] parallels: Add full dirty bitmap support, Alexander Ivanov, 2024/03/11
- [PATCH v5 02/22] parallels: Move inactivation code to a separate function, Alexander Ivanov, 2024/03/11
- [PATCH v5 03/22] parallels: Make mark_used() a global function, Alexander Ivanov, 2024/03/11
- [PATCH v5 07/22] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2024/03/11
- [PATCH v5 20/22] tests: Add parallels images support to test 165, Alexander Ivanov, 2024/03/11
- [PATCH v5 21/22] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2024/03/11
- [PATCH v5 01/22] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2024/03/11
- [PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed,
Alexander Ivanov <=
- [PATCH v5 15/22] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2024/03/11
- [PATCH v5 14/22] parallels: Preserve extensions cluster for non-transient extensions, Alexander Ivanov, 2024/03/11
- [PATCH v5 08/22] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 18/22] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 09/22] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2024/03/11
- [PATCH v5 04/22] parallels: Limit search in parallels_mark_used to the last marked claster, Alexander Ivanov, 2024/03/11
- [PATCH v5 13/22] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2024/03/11
- [PATCH v5 16/22] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2024/03/11
- [PATCH v5 06/22] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2024/03/11
- [PATCH v5 11/22] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2024/03/11