[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 02/22] parallels: Move inactivation code to a separate functio
From: |
Alexander Ivanov |
Subject: |
[PATCH v5 02/22] parallels: Move inactivation code to a separate function |
Date: |
Mon, 11 Mar 2024 19:18:30 +0100 |
We are going to add parallels image extensions storage and need a separate
function for inactivation code.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
block/parallels.c | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 072b1efd78..992362ce29 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1424,6 +1424,20 @@ fail:
return ret;
}
+static int GRAPH_RDLOCK parallels_inactivate(BlockDriverState *bs)
+{
+ BDRVParallelsState *s = bs->opaque;
+ int ret;
+
+ s->header->inuse = 0;
+ parallels_update_header(bs);
+
+ /* errors are ignored, so we might as well pass exact=true */
+ ret = bdrv_truncate(bs->file, s->data_end << BDRV_SECTOR_BITS, true,
+ PREALLOC_MODE_OFF, 0, NULL);
+
+ return ret;
+}
static void parallels_close(BlockDriverState *bs)
{
@@ -1432,12 +1446,7 @@ static void parallels_close(BlockDriverState *bs)
GRAPH_RDLOCK_GUARD_MAINLOOP();
if ((bs->open_flags & BDRV_O_RDWR) && !(bs->open_flags & BDRV_O_INACTIVE))
{
- s->header->inuse = 0;
- parallels_update_header(bs);
-
- /* errors are ignored, so we might as well pass exact=true */
- bdrv_truncate(bs->file, s->data_end << BDRV_SECTOR_BITS, true,
- PREALLOC_MODE_OFF, 0, NULL);
+ parallels_inactivate(bs);
}
parallels_free_used_bitmap(bs);
@@ -1476,6 +1485,7 @@ static BlockDriver bdrv_parallels = {
.bdrv_co_check = parallels_co_check,
.bdrv_co_pdiscard = parallels_co_pdiscard,
.bdrv_co_pwrite_zeroes = parallels_co_pwrite_zeroes,
+ .bdrv_inactivate = parallels_inactivate,
};
static void bdrv_parallels_init(void)
--
2.40.1
- [PATCH v5 00/22] parallels: Add full dirty bitmap support, Alexander Ivanov, 2024/03/11
- [PATCH v5 02/22] parallels: Move inactivation code to a separate function,
Alexander Ivanov <=
- [PATCH v5 03/22] parallels: Make mark_used() a global function, Alexander Ivanov, 2024/03/11
- [PATCH v5 07/22] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2024/03/11
- [PATCH v5 05/22] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2024/03/11
- [PATCH v5 20/22] tests: Add parallels images support to test 165, Alexander Ivanov, 2024/03/11
- [PATCH v5 21/22] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2024/03/11
- [PATCH v5 01/22] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2024/03/11
- [PATCH v5 12/22] parallels: drop dirty bitmap data if the image was not properly closed, Alexander Ivanov, 2024/03/11
- [PATCH v5 15/22] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2024/03/11
- [PATCH v5 14/22] parallels: Preserve extensions cluster for non-transient extensions, Alexander Ivanov, 2024/03/11
- [PATCH v5 08/22] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2024/03/11