Re: [PATCH v5 23/36] qapi/commands.py: enable checking with mypy

[Markus Armbruster]

John Snow <jsnow@redhat.com> writes:

> On 10/7/20 7:37 AM, Markus Armbruster wrote:
>> John Snow <jsnow@redhat.com> writes:
>> 
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>>> Reviewed-by: Cleber Rosa <crosa@redhat.com>
>>> ---
>>>   scripts/qapi/mypy.ini | 5 -----
>>>   1 file changed, 5 deletions(-)
>>>
>>> diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini
>>> index 5df11e53fd1..8ab9ac52cc4 100644
>>> --- a/scripts/qapi/mypy.ini
>>> +++ b/scripts/qapi/mypy.ini
>>> @@ -4,11 +4,6 @@ strict_optional = False
>>>   disallow_untyped_calls = False
>>>   python_version = 3.6
>>>   -[mypy-qapi.commands]
>>> -disallow_untyped_defs = False
>>> -disallow_incomplete_defs = False
>>> -check_untyped_defs = False
>>> -
>>>   [mypy-qapi.error]
>>>   disallow_untyped_defs = False
>>>   disallow_incomplete_defs = False
>> The equivalent change for  events.py you squashed into the commit
>> adding
>> type hints.  Any particular reason for not doing the same here?
>> 
>
> Just making my life easier for re-arranging commits and rebasing. By
> separating them out whenever I had > 1 fix patch prior, I was able to 
> freely re-arrange and re-order the prior fix patches.
>
> They can be squashed on commit if desired, but for my own sake and
> inability to predict review comments, they are separate.

I only asked because some are separate, and some are not.

Squashing on commit is an easy way toward consistency here.