[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 26/36] qapi/gen.py: Fix edge-case of _is_user_module
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 26/36] qapi/gen.py: Fix edge-case of _is_user_module |
|
Date: |
Tue, 6 Oct 2020 13:44:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/5/20 9:51 PM, John Snow wrote:
> The edge case is that if the name is '', this expression returns a
> string instead of a bool, which violates our declared type.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> scripts/qapi/gen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[PATCH v5 27/36] qapi/gen.py: add type hint annotations, John Snow, 2020/10/05