[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 26/36] qapi/gen.py: Fix edge-case of _is_user_module
From: |
John Snow |
Subject: |
[PATCH v5 26/36] qapi/gen.py: Fix edge-case of _is_user_module |
Date: |
Mon, 5 Oct 2020 15:51:48 -0400 |
The edge case is that if the name is '', this expression returns a
string instead of a bool, which violates our declared type.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
scripts/qapi/gen.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index f2e2746fea5..1bad37fc06b 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -243,7 +243,7 @@ def __init__(self, prefix, what, user_blurb, builtin_blurb,
pydoc):
@staticmethod
def _is_user_module(name):
- return name and not name.startswith('./')
+ return bool(name and not name.startswith('./'))
@staticmethod
def _is_builtin_module(name):
--
2.26.2