[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 23/36] qapi/commands.py: enable checking with mypy
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 23/36] qapi/commands.py: enable checking with mypy |
Date: |
Wed, 07 Oct 2020 13:37:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> ---
> scripts/qapi/mypy.ini | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini
> index 5df11e53fd1..8ab9ac52cc4 100644
> --- a/scripts/qapi/mypy.ini
> +++ b/scripts/qapi/mypy.ini
> @@ -4,11 +4,6 @@ strict_optional = False
> disallow_untyped_calls = False
> python_version = 3.6
>
> -[mypy-qapi.commands]
> -disallow_untyped_defs = False
> -disallow_incomplete_defs = False
> -check_untyped_defs = False
> -
> [mypy-qapi.error]
> disallow_untyped_defs = False
> disallow_incomplete_defs = False
The equivalent change for events.py you squashed into the commit adding
type hints. Any particular reason for not doing the same here?
[PATCH v5 20/36] qapi/events.py: Move comments into docstrings, John Snow, 2020/10/05
[PATCH v5 22/36] qapi/commands.py: add type hint annotations, John Snow, 2020/10/05
[PATCH v5 21/36] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/10/05
[PATCH v5 23/36] qapi/commands.py: enable checking with mypy, John Snow, 2020/10/05
- Re: [PATCH v5 23/36] qapi/commands.py: enable checking with mypy,
Markus Armbruster <=
[PATCH v5 25/36] qapi/source.py: delint with pylint, John Snow, 2020/10/05
[PATCH v5 26/36] qapi/gen.py: Fix edge-case of _is_user_module, John Snow, 2020/10/05
[PATCH v5 28/36] qapi/gen.py: Enable checking with mypy, John Snow, 2020/10/05
[PATCH v5 24/36] qapi/source.py: add type hint annotations, John Snow, 2020/10/05