Re: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeou

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeou

From:	Kevin Wolf
Subject:	Re: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout
Date:	Wed, 7 Oct 2020 12:59:26 +0200

Am 07.10.2020 um 01:58 hat John Snow geschrieben:
> The types and names of the parameters must match the socket.socket interface.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 09/20] python/qemu: make 'args' style arguments immutable, (continued)
- [PATCH 09/20] python/qemu: make 'args' style arguments immutable, John Snow, 2020/10/06
  - Re: [PATCH 09/20] python/qemu: make 'args' style arguments immutable, Philippe Mathieu-Daudé, 2020/10/07
- [PATCH 10/20] iotests.py: Adjust HMP kwargs typing, John Snow, 2020/10/06
- [PATCH 11/20] python/qemu: Add mypy type annotations, John Snow, 2020/10/06
  - Re: [PATCH 11/20] python/qemu: Add mypy type annotations, Kevin Wolf, 2020/10/07
    - Re: [PATCH 11/20] python/qemu: Add mypy type annotations, John Snow, 2020/10/07
- [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(), John Snow, 2020/10/06
  - Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(), Kevin Wolf, 2020/10/07
    - Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(), John Snow, 2020/10/07
- [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, John Snow, 2020/10/06
  - Re: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, Kevin Wolf <=
- [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, John Snow, 2020/10/06
  - Re: [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, Kevin Wolf, 2020/10/07
- [PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations, John Snow, 2020/10/06
  - Re: [PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations, Kevin Wolf, 2020/10/07
- [PATCH 16/20] python/console_socket: avoid encoding to/from string, John Snow, 2020/10/06
  - Re: [PATCH 16/20] python/console_socket: avoid encoding to/from string, Kevin Wolf, 2020/10/07
- [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, John Snow, 2020/10/06
  - Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, Philippe Mathieu-Daudé, 2020/10/07
  - Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, Kevin Wolf, 2020/10/07
    - Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, John Snow, 2020/10/07

Prev by Date: Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv()
Next by Date: Re: [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread
Previous by thread: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout
Next by thread: [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread
Index(es):
- Date
- Thread