Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise

From:	Kevin Wolf
Subject:	Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise
Date:	Wed, 7 Oct 2020 13:21:07 +0200

Am 07.10.2020 um 01:58 hat John Snow geschrieben:
> Use the "from ..." phrasing when re-raising errors to preserve their
> initial context, to help aid debugging when things go wrong.
> 
> This also silences a pylint 2.6.0+ error.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>

I don't really understand what this improves compared to the implicit
chaining we got before, but if pylint says so...

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, (continued)
- [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, John Snow, 2020/10/06
  - Re: [PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, Kevin Wolf, 2020/10/07
- [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, John Snow, 2020/10/06
  - Re: [PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, Kevin Wolf, 2020/10/07
- [PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations, John Snow, 2020/10/06
  - Re: [PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations, Kevin Wolf, 2020/10/07
- [PATCH 16/20] python/console_socket: avoid encoding to/from string, John Snow, 2020/10/06
  - Re: [PATCH 16/20] python/console_socket: avoid encoding to/from string, Kevin Wolf, 2020/10/07
- [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, John Snow, 2020/10/06
  - Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, Philippe Mathieu-Daudé, 2020/10/07
  - Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, Kevin Wolf <=
    - Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, John Snow, 2020/10/07
- [PATCH 19/20] python/qemu/qmp.py: Straighten out exception hierarchy, John Snow, 2020/10/06
  - Re: [PATCH 19/20] python/qemu/qmp.py: Straighten out exception hierarchy, Kevin Wolf, 2020/10/07
- [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered, John Snow, 2020/10/06
  - Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered, Philippe Mathieu-Daudé, 2020/10/07
  - Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered, Kevin Wolf, 2020/10/07
    - Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered, John Snow, 2020/10/07
    - Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered, John Snow, 2020/10/08
- [PATCH 20/20] python: add mypy config, John Snow, 2020/10/06
  - Re: [PATCH 20/20] python: add mypy config, Kevin Wolf, 2020/10/07

Prev by Date: Re: Fwd: Enable IOMMU Inside QEMU
Next by Date: Re: acceptance-system-fedora failures
Previous by thread: Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise
Next by thread: Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise
Index(es):
- Date
- Thread