[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv()
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv() |
|
Date: |
Wed, 7 Oct 2020 12:59:03 +0200 |
Am 07.10.2020 um 01:58 hat John Snow geschrieben:
> The type and parameter names of recv() should match socket.socket().
Should this be socket.socket without parentheses (the class name)?
socket.socket() is the constructor and it takes very different
parameters.
> OK, easy enough, but in the cases we don't pass straight through to the
> real socket implementation, we probably can't accept such flags. OK, for
> now, assert that we don't receive flags in such cases.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
- Re: [PATCH 08/20] python/machine.py: fix _popen access, (continued)
[PATCH 09/20] python/qemu: make 'args' style arguments immutable, John Snow, 2020/10/06
[PATCH 10/20] iotests.py: Adjust HMP kwargs typing, John Snow, 2020/10/06
[PATCH 11/20] python/qemu: Add mypy type annotations, John Snow, 2020/10/06
[PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(), John Snow, 2020/10/06
- Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(),
Kevin Wolf <=
[PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, John Snow, 2020/10/06
[PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, John Snow, 2020/10/06
[PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations, John Snow, 2020/10/06
[PATCH 16/20] python/console_socket: avoid encoding to/from string, John Snow, 2020/10/06
[PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise, John Snow, 2020/10/06