Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv()

[John Snow]

On 10/7/20 6:59 AM, Kevin Wolf wrote:
> Am 07.10.2020 um 01:58 hat John Snow geschrieben:
> > The type and parameter names of recv() should match socket.socket().
>
> Should this be socket.socket without parentheses (the class name)?
> socket.socket() is the constructor and it takes very different
> parameters.

You're right.

> > OK, easy enough, but in the cases we don't pass straight through to the
> > real socket implementation, we probably can't accept such flags. OK, for
> > now, assert that we don't receive flags in such cases.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Thanks!