[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 24/25] qapi: Improve reporting of redefinition
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 24/25] qapi: Improve reporting of redefinition |
|
Date: |
Tue, 24 Sep 2019 14:53:17 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 8:28 AM, Markus Armbruster wrote:
> Point to the previous definition, unless it's a built-in.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> if other_ent:
> + if other_ent.info:
> + where = QAPIError(other_ent.info, None, "previous
> definition")
> + raise QAPISemError(
> + ent.info,
> + "'%s' is already defined\n%s" % (ent.name, where))
> raise QAPISemError(
> ent.info, "%s is already defined" % other_ent.describe())
Nice.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 03/25] qapi: New QAPISourceInfo, replacing dict, (continued)
- [PATCH 02/25] qapi: Rename .owner to .defined_in, Markus Armbruster, 2019/09/24
- [PATCH 10/25] qapi: Use check_name_str() where it suffices, Markus Armbruster, 2019/09/24
- [PATCH 17/25] qapi: Move context-free checking to the proper place, Markus Armbruster, 2019/09/24
- [PATCH 11/25] qapi: Report invalid '*' prefix like any other invalid name, Markus Armbruster, 2019/09/24
- [PATCH 24/25] qapi: Improve reporting of redefinition, Markus Armbruster, 2019/09/24
- Re: [PATCH 24/25] qapi: Improve reporting of redefinition,
Eric Blake <=
- [PATCH 15/25] qapi: Inline check_name() into check_union(), Markus Armbruster, 2019/09/24
- [PATCH 07/25] qapi: Improve reporting of member name clashes, Markus Armbruster, 2019/09/24
- [PATCH 13/25] qapi: Make check_type()'s array case a bit more obvious, Markus Armbruster, 2019/09/24
- [PATCH 18/25] qapi: Improve reporting of invalid 'if' errors, Markus Armbruster, 2019/09/24
- [PATCH 12/25] qapi: Move check for reserved names out of add_name(), Markus Armbruster, 2019/09/24