qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 15/25] qapi: Inline check_name() into check_union()


From: Eric Blake
Subject: Re: [PATCH 15/25] qapi: Inline check_name() into check_union()
Date: Tue, 24 Sep 2019 11:39:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 9/24/19 8:28 AM, Markus Armbruster wrote:
> check_name() consists of check_name_is_str() and check_name_str().
> check_union() relies on the latter to catch optional discriminators.
> The next commit will replace that by a more straightforward check.
> Inlining check_name() into check_union() now should make that easier
> to review.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi/common.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]