Re: [PATCH 07/25] qapi: Improve reporting of member name clashes

[Eric Blake]

On 9/24/19 8:28 AM, Markus Armbruster wrote:
> We report name clashes like this:
> 
>     struct-base-clash.json: In struct 'Sub':
>     struct-base-clash.json:5: 'name' (member of Sub) collides with 'name' 
> (member of Base)
> 
> The "(member of Sub)" is redundant with "In struct 'Sub'".  Comes from
> QAPISchemaMember.describe().  Pass info to it, so it can detect the
> redundancy and avoid it.  Result:
> 
>     struct-base-clash.json: In struct 'Sub':
>     struct-base-clash.json:5: member 'name' collides with member 'name' of 
> type 'Base'
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

The resulting error messages are indeed nicer.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature