[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimizat
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization |
|
Date: |
Mon, 23 Sep 2019 18:49:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 23/09/19 18:00, Richard Henderson wrote:
> On 9/23/19 2:45 AM, Paolo Bonzini wrote:
>> On 22/09/19 05:54, Richard Henderson wrote:
>>> +/*
>>> + * Forced inlining may be desired to encourage constant propagation
>>> + * of function parameters. However, it can also make debugging harder,
>>> + * so disable it for a non-optimizing build.
>>> + */
>>> +#if defined(__OPTIMIZE__) && __has_attribute(always_inline)
>>> +#define QEMU_ALWAYS_INLINE __attribute__((always_inline))
>>
>> GCC doesn't have __has_attribute, does it?
>
> It does, since at least gcc 5. And now I realize that's only a reorganization
> of the support and not when it was introduced.
Hmm, still we support 4.8 and always_inline is much older than that. So
I'm not sure it's useful to test it.
Paolo
- [PATCH v3 05/20] exec: Promote TARGET_PAGE_MASK to target_long, (continued)
[PATCH v3 09/20] cputlb: Replace switches in load/store_helper with callback, Richard Henderson, 2019/09/21
[PATCH v3 11/20] exec: Adjust notdirty tracing, Richard Henderson, 2019/09/21