[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/20] exec: Tidy TARGET_PAGE_ALIGN
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v3 06/20] exec: Tidy TARGET_PAGE_ALIGN |
|
Date: |
Mon, 23 Sep 2019 10:30:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 22.09.19 05:54, Richard Henderson wrote:
> Use TARGET_PAGE_MASK twice instead of TARGET_PAGE_SIZE once.
> This is functionally identical, but will help a following patch.
>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> include/exec/cpu-all.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> index 34d36cebca..5246770271 100644
> --- a/include/exec/cpu-all.h
> +++ b/include/exec/cpu-all.h
> @@ -226,7 +226,8 @@ extern const TargetPageBits target_page;
>
> #define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
> #define TARGET_PAGE_MASK ((target_long)-1 << TARGET_PAGE_BITS)
> -#define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) &
> TARGET_PAGE_MASK)
> +#define TARGET_PAGE_ALIGN(addr) \
> + (((addr) + ~TARGET_PAGE_MASK) & TARGET_PAGE_MASK)
>
> /* Using intptr_t ensures that qemu_*_page_mask is sign-extended even
> * when intptr_t is 32-bit and we are aligning a long long.
>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb
- [PATCH v3 01/20] exec: Use TARGET_PAGE_BITS_MIN for TLB flags, (continued)
- [PATCH v3 01/20] exec: Use TARGET_PAGE_BITS_MIN for TLB flags, Richard Henderson, 2019/09/21
- [PATCH v3 02/20] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/09/21
- [PATCH v3 04/20] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/09/21
- [PATCH v3 03/20] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/21
- [PATCH v3 05/20] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/09/21
- [PATCH v3 06/20] exec: Tidy TARGET_PAGE_ALIGN, Richard Henderson, 2019/09/21
- Re: [PATCH v3 06/20] exec: Tidy TARGET_PAGE_ALIGN,
David Hildenbrand <=
- [PATCH v3 07/20] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/21
- [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization, Richard Henderson, 2019/09/21
[PATCH v3 09/20] cputlb: Replace switches in load/store_helper with callback, Richard Henderson, 2019/09/21