[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/20] exec: Split out variable page size support to exec-
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v3 02/20] exec: Split out variable page size support to exec-vary.c |
|
Date: |
Mon, 23 Sep 2019 09:27:37 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/23/19 1:26 AM, David Hildenbrand wrote:
>> +void finalize_target_page_bits(void)
>> +{
>> +#ifdef TARGET_PAGE_BITS_VARY
>> + if (target_page_bits == 0) {
>> + target_page_bits = TARGET_PAGE_BITS_MIN;
>> + }
>> + target_page_bits_decided = true;
>> +#endif
>> +}
> I wonder if it would be nicer to handle this in the header file instead,
> providing dummy functions there.
No can do, because set_preferred_target_page_bits is used by vl.c, which is
compiled once and so does not have access to cpu.h definitions.
r~
- [PATCH v3 00/20] Move rom and notdirty handling to cputlb, Richard Henderson, 2019/09/21
- [PATCH v3 01/20] exec: Use TARGET_PAGE_BITS_MIN for TLB flags, Richard Henderson, 2019/09/21
- [PATCH v3 02/20] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/09/21
- [PATCH v3 04/20] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/09/21
- [PATCH v3 03/20] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/21
- [PATCH v3 05/20] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/09/21
- [PATCH v3 06/20] exec: Tidy TARGET_PAGE_ALIGN, Richard Henderson, 2019/09/21
- [PATCH v3 07/20] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/21
- [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization, Richard Henderson, 2019/09/21