[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ
From: |
Alex Bennée |
Subject: |
Re: [PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ |
Date: |
Mon, 23 Sep 2019 17:33:20 +0100 |
User-agent: |
mu4e 1.3.4; emacs 27.0.50 |
Richard Henderson <address@hidden> writes:
> We were setting the wrong bit. The fp_status.flush_to_zero
> setting is overwritten
".. in the generated code.."?
> by either the constant 1 or the value
> of fpcr_flush_to_zero depending on bits within an fp insn.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/alpha/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/alpha/helper.c b/target/alpha/helper.c
> index 6c1703682e..10602fb339 100644
> --- a/target/alpha/helper.c
> +++ b/target/alpha/helper.c
> @@ -71,7 +71,7 @@ void cpu_alpha_store_fpcr(CPUAlphaState *env, uint64_t val)
> env->fp_status.flush_inputs_to_zero = 1;
> }
> if (env->swcr & SWCR_MAP_UMZ) {
> - env->fp_status.flush_to_zero = 1;
> + env->fpcr_flush_to_zero = 1;
> }
> env->fpcr_exc_enable &= ~(alpha_ieee_swcr_to_fpcr(env->swcr) >> 32);
> #endif
--
Alex Bennée
- [PATCH 0/7] target/alpha: Fix linux-user exception for CVTTQ, Richard Henderson, 2019/09/21
- [PATCH 1/7] target/alpha: Use array for FPCR_DYN conversion, Richard Henderson, 2019/09/21
- [PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ, Richard Henderson, 2019/09/21
- Re: [PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ,
Alex Bennée <=
- [PATCH 5/7] target/alpha: Write to fpcr_flush_to_zero once, Richard Henderson, 2019/09/21
- [PATCH 3/7] target/alpha: Fix SWCR_TRAP_ENABLE_MASK, Richard Henderson, 2019/09/21
- [PATCH 7/7] target/alpha: Tidy helper_fp_exc_raise_s, Richard Henderson, 2019/09/21
- [PATCH 6/7] target/alpha: Mask IOV exception with INV for user-only, Richard Henderson, 2019/09/21
- [PATCH 4/7] target/alpha: Handle SWCR_MAP_DMZ earlier, Richard Henderson, 2019/09/21