Re: [Oroborus-user] New version 2.0.6

[Chris Osgood]

No, that version still crashes.  I "fixed" my version by checking the
return value of XGetClassHint.  I say "fixed" because even with that
change it crashed one time.  I have not been able to get it to repeat
though.  I noticed that there are lots of XGet--- calls that do not check
the return value for failure.  My guess is there is more than one area
where something similar is happening.

This was my fix:

int
clientInBorderlessList (Client * c)
{
  XClassHint *class_res;
  char *win_class_name;
  char *tok;
  char *buf;
  size_t strSize;
  int err;

#ifdef DEBUG
  printf ("entering clientInBorderlessList\n");
#endif

  class_res = xmalloc (sizeof (XClassHint));

  err = XGetClassHint (dpy, c->window, class_res);

  if (err && class_res->res_name)
    win_class_name = class_res->res_name;
  else
    {
      XFree (class_res);
      return False;
    }


--
// Chris <address@hidden>
Functional Future
757-868-4387

On Fri, 12 Jul 2002, Stefan Pfetzing wrote:

> * Chris Osgood <address@hidden> [020712 03:25]:
> Hi,
> > Yes, it crashes in client.c at line 1747.
> >
> > The problem appears to be that XGetClassHint() is failing (return value 0
> > sometimes).  Then later the strcasecmp crashes because win_class_name is
> > just garbage.
> Could you check if with:
>
> http://www.dreamind.de/files/oroborus_2.0.6-1_i386.deb
>
> the problem still appears?