Re: [Mingw-cross-env-list] [patches] upgrade packages exiv2 gettext glib gst-plugins-good libevent libtool

[Tony Theodore]

On 6 June 2010 17:50, Volker Grabsch <address@hidden> wrote:
> Tony Theodore <address@hidden> schrieb:
>> On 6 June 2010 09:22, Mark Brand <address@hidden> wrote:
>> >
>> > If the problem persists, you might want to take a look at
>> > "glib-2-optional-gettext.patch" that was removed because it seemed to be
>> > already applied and unnecessary.
>
> No, only a part of that patch was accepted by upstream. (see below)
>
> I restored and fixed the glib patches.
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/faaf8d7f9b85
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/7ffb6c25180d
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/bc7932ed89fc

I think that will fix it - it's running from make clean now.

>> > http://hg.savannah.gnu.org/hgweb/mingw-cross-env/diff/ae504f83b68d/src/glib-2-optional-gettext.patch
>> >
>> > Maybe something like it is still needed on your system.
>>
>> Thanks Mark, I think I see now. That patch is actually three issues -
>> configure warnings about gettext, a GTK_DOC_CHECK fix, and an
>> LC_MESSAGES fix.
>
> No, the GTK_DOC_CHECK fix is a separate patch.

I think I was trying to look at previous versions of the patches and
got confused with the numbering changes.

> That patch fixes exactly the Gettext issues, i.e.
>
>    * ./configure ERROR -> WARN
>    * avoid LC_MESSAGES
>    * provide dummy gettext() when libintl is disabled
>
>> I think the only one that was reported upstream is
>> the LC_MESSAGES one.
>
> No, all 3 parts are reported, but only the LC_MESSAGES
> part was accepted yet.
>
> Please have a look at the URL included in the patch:
> https://bugzilla.gnome.org/show_bug.cgi?id=617004#c8
>
> It's only the GTK_DOC_CHECK stuff which is not reported,
> because it isn't a clean solution.

Thanks,

Tony