Re: [lmi] wx-2.9.5-rc1 regression: proposed patch(es)

[Vadim Zeitlin]

On Tue, 23 Jul 2013 02:29:34 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2013-07-23 00:46Z, Vadim Zeitlin wrote:
GC> [...snip patch for wx 'minimal' sample...]
GC> >  TAB simply didn't work at all.
GC> > 
GC> >  I've fixed this now in http://trac.wxwidgets.org/changeset/74583 (but you
GC> > also need the previous revision to compile it, i.e. you can't take just
GC> > this patch if you were tempted to do it after the snapshot problems) and
GC> > now TAB navigation does work correctly in the simple example above ...
GC> 
GC> I'm not sure I understand. I don't need samples/minimal; I just
GC> want to rebuild wx and lmi. Does this...
GC> > also need the previous revision to compile it
GC> ...mean that changeset/74583 alone won't suffice, and I'll need
GC> the immediately preceding changeset/74582 as well?

 Sorry about this, I should have been more explicit.

 First, I only brought samples/minimal into discussion as a simple way to
test for this bug, e.g. if you download a new snapshot it would be simpler
and faster to test the sample with it rather than rebuilding the entire
LMI. Of course, you don't _need_ it in any way, it's just a way to test for
this bug presence.

 Second, r74583 indeed relies on r74582 so you need to either take both
patches or get the latest sources from SVN or Git or daily snapshot (the
next one, i.e. 20130724 one, as I think I did them too late for the today's
snapshot).

 Sorry once again for not being clear and I hope this email clears it up,
VZ