Re: [lmi] wx-2.9.5-rc1 regression: proposed patch(es)

[Vadim Zeitlin]

On Mon, 22 Jul 2013 00:12:18 +0000 Greg Chicares <address@hidden> wrote:

GC> However, this problem still remains:
GC> 
GC>   http://lists.nongnu.org/archive/html/lmi/2013-07/msg00038.html
GC> | on the "Solve" tab,
GC> | every control is in a groupbox, and none can be reached with the Tab key.
GC> 
GC> which is a regression from the last build that used wx-2.9.3 .
GC> How can we resolve that?

 This turned out another bug in wxWidgets, thanks for finding it! Somehow
(I could find when exactly but it probably doesn't matter) tab navigation
got completely broken for wxRadioBox in wxMSW as it always refused to
accept focus. This could be seen e.g. using the following trivial patch to
the wxWidgets minimal sample:

----------------------------------------------------------------------------
diff --git a/samples/minimal/minimal.cpp b/samples/minimal/minimal.cpp
index a78e462..383e0bd 100644
--- a/samples/minimal/minimal.cpp
+++ b/samples/minimal/minimal.cpp
@@ -172,6 +172,14 @@ bool MyApp::OnInit()
     CreateStatusBar(2);
     SetStatusText("Welcome to wxWidgets!");
 #endif // wxUSE_STATUSBAR
+
+    wxPanel* p = new wxPanel(this);
+    wxPanel* p1 = new wxPanel(p, wxID_ANY, wxPoint(0, 0), wxSize(200, 100));
+    wxPanel* p2 = new wxPanel(p, wxID_ANY, wxPoint(200, 0), wxSize(200, 100));
+    wxString choices1[] = { "Allegro Moderato", "Romanza: Andante", "Rondo: 
Allegro vivace" };
+    new wxRadioBox(p1, wxID_ANY, "Box &1", wxPoint(5, 5), wxSize(190, 90), 
WXSIZEOF(choices1), choices1, 1);
+    wxString choices2[] = { "Allegro Maestoso", "Andante", "Rondo: Allegro" };
+    new wxRadioBox(p2, wxID_ANY, "Box &2", wxPoint(5, 5), wxSize(190, 90), 
WXSIZEOF(choices2), choices2, 1);
 }


----------------------------------------------------------------------------

 TAB simply didn't work at all.


 I've fixed this now in http://trac.wxwidgets.org/changeset/74583 (but you
also need the previous revision to compile it, i.e. you can't take just
this patch if you were tempted to do it after the snapshot problems) and
now TAB navigation does work correctly in the simple example above ...

GC> I'll mention an apparently similar regression in case that makes
GC> this easier to track down. On the "Funds" tab...
GC> 
GC> (a) if the first control is set to "Choose funds", then I can reach
GC> that radiobox with the Tab key; but
GC> 
GC> (b) if it's set to "Override fund", then it's unreachable with Tab.
GC> 
GC> Either way, Tab won't reach the radioboxes at lower right with
GC> "Net rate" and "Fixed loan rate".

 ... and also in all those cases in LMI. So I hope that this is really all
that was needed to fix this problem.

 Thanks again for finding this bug and please let me know if you still see
anything wrong.

 Thanks in advance,
VZ