Re: [lmi] pre-wx-2.9.5 appearance changes

[Vadim Zeitlin]

On Sun, 14 Jul 2013 16:06:10 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2013-07-13 00:25Z, Vadim Zeitlin wrote:
GC> > On Fri, 12 Jul 2013 19:04:04 +0000 Greg Chicares <address@hidden> wrote:
GC> > 
GC> > GC> Compared to the wx-2.9.3 release, on msw xp sp3 (with an
GC> > GC> unusual graphics card and an unusual screen resolution),
GC> > GC> I notice two changes in the appearance of lmi's toolbar:
GC> [...]
GC> >  I'll build LMI itself tomorrow and see if I at least the problem there.
GC> > Do I understand correctly that you are testing under Windows XP with 
visual
GC> > themes disabled?
GC> 
GC> I wasn't sure what "themes" are, but I looked into it a little.
GC> In "Display Properties", "Theme" is "Windows XP (Modified)".

 Thanks, I was wrong about themes being disabled, the real reason for the
themeless-looking buttons was the lack of manifest that I subsequently
discovered. The confusing thing is that *all* of the possible cases are all
subtly different:

1. Application with a manifest running on a system with themes enabled.
2. Application with a manifest running on a system with themes disabled.
3. Application for which theming was explicitly disabled in its
   "Properties" dialog using the "Disable visual themes" checkbox on the
   "Compatibility" page of the dialog.
4. Application without the manifest.

 With the latest fixes, the toolbar buttons appear correctly in the cases
(1), (2) and (3) under both Windows XP and 7 (I assume Vista and 8 work too
because there are no significant differences with 7 in this area but I
didn't test them yet) and it's only the case (4) that is problematic -- but
it doesn't occur for LMI and I see no reason for not including the manifest
intentionally, so I think in practice the problem is fully fixed.

 Best regards,
VZ