Re: [lmi] wxmsw-2.9.0 (svn trunk) anomaly

[Vaclav Slavik]

On Sun, 2009-03-29 at 12:10 +0000, Greg Chicares wrote:
> > (2) I also added wxXmlResource::LoadFile(wxFileName) that doesn't suffer
> > from this ambiguity in r59150
> > (http://svn.wxwidgets.org/viewvc/wx?view=rev&revision=59150). In LMI
> > code, calls to xml_resources.Load() could -- and in my opinion should --
> > be replaced with xml_resources.LoadFile() to avoid the ambiguity.
> 
> Given that I've done (3), is it still your opinion that lmi should
> use LoadFile() instead of Load()?

Yes. It's better to pass a filename argument to a function that accepts
filenames than to a function that accepts URIs and rely on the fact that
a filename is a particular form of URI in wxFileSystem. (Or, in case of
wxXmlResource::Load(), on its heuristics to recognize filenames vs.
URIs.)

Vaclav