[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining regis
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach |
Date: |
Wed, 22 Jul 2020 11:05:13 -0400 (EDT) |
branch: master
commit a43eb0f238a0fd7e819fe05397f0821d6954c6d6
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Add a comment explaining register_all() approach
Leave a note explaining that this solution is chosen because it's much
simpler (yet sufficient for our needs) than the other ones.
---
census_view.cpp | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/census_view.cpp b/census_view.cpp
index ccc6815..6f0d6a7 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1378,6 +1378,10 @@ class table_string_converter : public
table_type_converter
void
table_custom_type_converter::register_all(wxGrid* grid)
{
+ // We could implement some kind of automatic registration, but it doesn't
+ // seem to be worth it for now, as we only have a few custom converters,
+ // all of which defined in this single file, so it's simpler to just list
+ // them explicitly here.
table_sequence_converter{}.register_data_type(grid);
table_double_range_converter{}.register_data_type(grid);
table_date_converter{}.register_data_type(grid);
- [lmi-commits] [lmi] master 03d33ab 14/46: Make DatumSequenceEditorEvtHandler::entry_ const, (continued)
- [lmi-commits] [lmi] master 03d33ab 14/46: Make DatumSequenceEditorEvtHandler::entry_ const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 0e2a694 16/46: Replace DatumSequenceEditorEvtHandler with a lambda, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3e9f8af 02/46: Add census_view variant with wxGrid, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 25a989e 10/46: Make table_type_converter::get_all() map const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 12940dc 09/46: Define static map in more compact way, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master e1fdb77 12/46: Use Bind() in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7e048d0 15/46: Remove apparently unnecessary wxEVT_CHAR handler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::get_by_value() to just get(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 1dacd5c 22/46: Move register_all() to table_custom_type_converter, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach,
Greg Chicares <=
- [lmi-commits] [lmi] master 4dcae52 34/46: Don't change default wxGrid lines colour, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 342b9f5 27/46: Always resize columns in CensusGridView::update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 395e268 41/46: Remove unnecessary calls to Update() when toggling autosize, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 713d56f 46/46: Fix defect introduced 20200608T2219Z: warning not suppressed, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 6281a6d 20/46: Make object returned by table_type_converter::get_impl() const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b85da3e 24/46: Clarify the comment about CensusViewDataViewModel wrappers, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5423df7 25/46: Remove separate table_type_converter::type(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f82b136 31/46: Remove unnecessary make_cell_number_column_read_only() function, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 9f1cb2e 39/46: Only auto-size columns when they change, not after each update, Greg Chicares, 2020/07/22