[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 9f1cb2e 39/46: Only auto-size columns when th
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 9f1cb2e 39/46: Only auto-size columns when they change, not after each update |
Date: |
Wed, 22 Jul 2020 11:05:16 -0400 (EDT) |
branch: master
commit 9f1cb2e3844ac42e09620931d1bf02860ac024fa
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Only auto-size columns when they change, not after each update
Doing this every time makes census view unusably slow for big censuses.
---
census_view.cpp | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index 95fe6a6..81e564f 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -2274,19 +2274,20 @@ void CensusGridView::update_visible_columns()
grid_table_->AppendCols(new_columns_count - old_columns_count);
}
+ // Recompute the best fitting sizes if the columns have changed.
+ // Ideally, we would only do it for the new columns, but this would be
+ // more complicated, and for now we prefer to keep the things simple.
+ if(autosize_columns_)
+ {
+ // Pass false to avoid setting min size to the best size.
+ grid_window_->AutoSizeColumns(false);
+ }
+
grid_window_->SetGridCursor
(cursor_row
,std::min(cursor_col, new_columns_count - 1)
);
}
-
- // Even if the visible columns are the same as before, their contents could
- // have changed, so always auto-size them if we're configured to do so.
- if(autosize_columns_)
- {
- // Pass false to avoid setting min size to the best size.
- grid_window_->AutoSizeColumns(false);
- }
}
char const* CensusView::icon_xrc_resource() const
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach, (continued)
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 4dcae52 34/46: Don't change default wxGrid lines colour, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 342b9f5 27/46: Always resize columns in CensusGridView::update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 395e268 41/46: Remove unnecessary calls to Update() when toggling autosize, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 713d56f 46/46: Fix defect introduced 20200608T2219Z: warning not suppressed, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 6281a6d 20/46: Make object returned by table_type_converter::get_impl() const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b85da3e 24/46: Clarify the comment about CensusViewDataViewModel wrappers, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5423df7 25/46: Remove separate table_type_converter::type(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f82b136 31/46: Remove unnecessary make_cell_number_column_read_only() function, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 9f1cb2e 39/46: Only auto-size columns when they change, not after each update,
Greg Chicares <=
- [lmi-commits] [lmi] master b3ac65b 43/46: Allow wxGrid to compute census view column sizes more efficiently, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master ece93a0 17/46: Make check for Alt-Enter more obvious in the code, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b57ed4a 18/46: Remove deleted DatumSequenceEditor copy-related methods, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 041ccfc 30/46: Optimize changing grid columns number too, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 53a288a 33/46: Restore "delete_cells" update UI handler for CensusDVCView, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3c3d0c0 36/46: Explain grid customizations in the function creating it, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 337d81f 37/46: Make UponDeleteCells() more efficient for large censuses, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 2922db9 44/46: Disallow single cell operations when non-current row is selected, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master d337a22 45/46: Upgrade wx, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c679655 19/46: Replace table_type_converter::get_all() with register_all(), Greg Chicares, 2020/07/22