[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master f82b136 31/46: Remove unnecessary make_cell_n
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master f82b136 31/46: Remove unnecessary make_cell_number_column_read_only() function |
Date: |
Wed, 22 Jul 2020 11:05:14 -0400 (EDT) |
branch: master
commit f82b1366721b09a41f0f64fd5c70c0e5dc64435a
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Remove unnecessary make_cell_number_column_read_only() function
This function is simple and was called only once after the changes of
the previous commit, so simply inline it into its caller.
---
census_view.cpp | 28 ++++++++++++----------------
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index 32b5206..4adb583 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1482,13 +1482,7 @@ class CensusViewGridTable
// Cell serial number: always shown in the first column.
static int const Col_CellNum = 0;
- explicit CensusViewGridTable(CensusGridView& view)
- :view_ {view}
- {
- wxGrid const* grid = view.grid_window_;
- SetAttrProvider(new(wx) CensusViewGridCellAttrProvider(grid));
- make_cell_number_column_read_only();
- }
+ explicit CensusViewGridTable(CensusGridView& view);
// return the number of rows and columns in this table.
int GetNumberRows() override;
@@ -1508,8 +1502,6 @@ class CensusViewGridTable
wxString GetColLabelValue(int col) override;
- void make_cell_number_column_read_only();
-
std::string const& col_name(int col) const;
Input& row_at(int row);
@@ -1538,6 +1530,17 @@ class CensusViewGridTable
std::vector<int> visible_columns_;
};
+CensusViewGridTable::CensusViewGridTable(CensusGridView& view)
+ :view_ {view}
+{
+ wxGrid const* grid = view.grid_window_;
+ SetAttrProvider(new(wx) CensusViewGridCellAttrProvider(grid));
+
+ auto attr = new(wx) wxGridCellAttr();
+ attr->SetReadOnly();
+ SetColAttr(attr, 0);
+}
+
int CensusViewGridTable::GetNumberRows()
{
return lmi::ssize(view_.cell_parms());
@@ -1708,13 +1711,6 @@ bool CensusViewGridTable::DeleteCols(size_t pos, size_t
num_cols)
return true;
}
-void CensusViewGridTable::make_cell_number_column_read_only()
-{
- auto attr = new(wx) wxGridCellAttr();
- attr->SetReadOnly();
- SetColAttr(attr, 0);
-}
-
inline std::string const& CensusViewGridTable::col_name(int col) const
{
LMI_ASSERT(0 < col);
- [lmi-commits] [lmi] master 1dacd5c 22/46: Move register_all() to table_custom_type_converter, (continued)
- [lmi-commits] [lmi] master 1dacd5c 22/46: Move register_all() to table_custom_type_converter, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 4dcae52 34/46: Don't change default wxGrid lines colour, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 342b9f5 27/46: Always resize columns in CensusGridView::update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 395e268 41/46: Remove unnecessary calls to Update() when toggling autosize, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 713d56f 46/46: Fix defect introduced 20200608T2219Z: warning not suppressed, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 6281a6d 20/46: Make object returned by table_type_converter::get_impl() const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b85da3e 24/46: Clarify the comment about CensusViewDataViewModel wrappers, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5423df7 25/46: Remove separate table_type_converter::type(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f82b136 31/46: Remove unnecessary make_cell_number_column_read_only() function,
Greg Chicares <=
- [lmi-commits] [lmi] master 9f1cb2e 39/46: Only auto-size columns when they change, not after each update, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b3ac65b 43/46: Allow wxGrid to compute census view column sizes more efficiently, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master ece93a0 17/46: Make check for Alt-Enter more obvious in the code, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b57ed4a 18/46: Remove deleted DatumSequenceEditor copy-related methods, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 041ccfc 30/46: Optimize changing grid columns number too, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 53a288a 33/46: Restore "delete_cells" update UI handler for CensusDVCView, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3c3d0c0 36/46: Explain grid customizations in the function creating it, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 337d81f 37/46: Make UponDeleteCells() more efficient for large censuses, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 2922db9 44/46: Disallow single cell operations when non-current row is selected, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master d337a22 45/46: Upgrade wx, Greg Chicares, 2020/07/22