[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std:
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap() |
Date: |
Wed, 22 Jul 2020 11:05:09 -0400 (EDT) |
branch: master
commit 804111d4b1a9373e48c767df323273f26972f7f8
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Remove unnecessary use of std::swap()
This could be useful to avoid copying in C++98, but since C++11 we can
simply use move-assignment instead, so do it as the intention of the
code is to only update visible_columns_, not to swap anything.
---
census_view.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/census_view.cpp b/census_view.cpp
index 3b5fa7e..a3334b0 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1648,7 +1648,7 @@ class CensusViewGridTable
void set_visible_columns(std::vector<int>&& new_visible_columns)
{
- std::swap(new_visible_columns, visible_columns_);
+ visible_columns_ = std::move(new_visible_columns);
}
private:
- [lmi-commits] [lmi] master 14ac975 03/46: Use at() instead of operator[] in non-performance-critical code, (continued)
- [lmi-commits] [lmi] master 14ac975 03/46: Use at() instead of operator[] in non-performance-critical code, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 193e804 01/46: Refactor census view to enable several implementations, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c094807 05/46: Remove unnecessary altColor_ member variable, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3d86a92 06/46: Use simpler wxGrid::AssignTable(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c9e743f 08/46: Remove extra blank line from census_view.hpp, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5ee4b04 13/46: Improve comments in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 03d33ab 14/46: Make DatumSequenceEditorEvtHandler::entry_ const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 0e2a694 16/46: Replace DatumSequenceEditorEvtHandler with a lambda, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3e9f8af 02/46: Add census_view variant with wxGrid, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(),
Greg Chicares <=
- [lmi-commits] [lmi] master 25a989e 10/46: Make table_type_converter::get_all() map const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 12940dc 09/46: Define static map in more compact way, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master e1fdb77 12/46: Use Bind() in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7e048d0 15/46: Remove apparently unnecessary wxEVT_CHAR handler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::get_by_value() to just get(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 1dacd5c 22/46: Move register_all() to table_custom_type_converter, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 4dcae52 34/46: Don't change default wxGrid lines colour, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 342b9f5 27/46: Always resize columns in CensusGridView::update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency, Greg Chicares, 2020/07/22