[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 14ac975 03/46: Use at() instead of operator[]
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 14ac975 03/46: Use at() instead of operator[] in non-performance-critical code |
Date: |
Wed, 22 Jul 2020 11:05:08 -0400 (EDT) |
branch: master
commit 14ac97555944ac8522e2ffa85326a2b1f96bbaf6
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Use at() instead of operator[] in non-performance-critical code
Always use safer method unless the use of operator[] is warranted by the
performance considerations, which is not the case in CensusViewGridTable
methods here.
---
census_view.cpp | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index 1c1994d..3b5fa7e 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1700,7 +1700,7 @@ void CensusViewGridTable::SetValue(int row, int col,
wxString const& value)
cell = new_val;
- Input& model = view_.cell_parms()[row];
+ Input& model = view_.cell_parms().at(row);
model.Reconcile();
view_.document().Modify(true);
@@ -1842,17 +1842,17 @@ inline std::string const&
CensusViewGridTable::col_name(int col) const
{
LMI_ASSERT(0 < col);
// "- 1" because first column is cell serial number.
- return all_headers()[visible_columns_[col - 1]];
+ return all_headers().at(visible_columns_.at(col - 1));
}
inline Input& CensusViewGridTable::row_at(int row)
{
- return view_.cell_parms()[row];
+ return view_.cell_parms().at(row);
}
inline Input const& CensusViewGridTable::row_at(int row) const
{
- return view_.cell_parms()[row];
+ return view_.cell_parms().at(row);
}
inline any_member<Input>& CensusViewGridTable::cell_at(int row, int col)
@@ -1877,7 +1877,7 @@ inline any_member<Input> const&
CensusViewGridTable::cell_at(int row, std::strin
inline std::vector<std::string> const& CensusViewGridTable::all_headers() const
{
- return view_.case_parms()[0].member_names();
+ return view_.case_parms().at(0).member_names();
}
namespace
- [lmi-commits] [lmi] master updated (6977670 -> 713d56f), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 14ac975 03/46: Use at() instead of operator[] in non-performance-critical code,
Greg Chicares <=
- [lmi-commits] [lmi] master 193e804 01/46: Refactor census view to enable several implementations, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c094807 05/46: Remove unnecessary altColor_ member variable, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3d86a92 06/46: Use simpler wxGrid::AssignTable(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c9e743f 08/46: Remove extra blank line from census_view.hpp, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5ee4b04 13/46: Improve comments in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 03d33ab 14/46: Make DatumSequenceEditorEvtHandler::entry_ const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 0e2a694 16/46: Replace DatumSequenceEditorEvtHandler with a lambda, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3e9f8af 02/46: Add census_view variant with wxGrid, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(), Greg Chicares, 2020/07/22