[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequ
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequenceEditorEvtHandler |
Date: |
Wed, 22 Jul 2020 11:05:10 -0400 (EDT) |
branch: master
commit ba151915dc9725b84e5f05f096261ca906e32121
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Stop using wxRTTI in DatumSequenceEditorEvtHandler
There is no need to make wxRTTI aware of this class, as we never need to
create it by name, and this allows to avoid having an artificial default
ctor in it.
---
census_view.cpp | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index 4f0bd45..dfa14b7 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1009,9 +1009,7 @@ class DatumSequenceEditorEvtHandler
:public wxEvtHandler
{
public:
- // wxIMPLEMENT_DYNAMIC_CLASS requires the default constructor
- // so add the default value for the entry parameter.
- explicit DatumSequenceEditorEvtHandler(InputSequenceEntry* entry = nullptr)
+ explicit DatumSequenceEditorEvtHandler(InputSequenceEntry* entry)
:entry_(entry)
{
}
@@ -1064,12 +1062,9 @@ class DatumSequenceEditorEvtHandler
InputSequenceEntry* entry_{};
DECLARE_EVENT_TABLE()
- DECLARE_DYNAMIC_CLASS(DatumSequenceEditorEvtHandler)
DECLARE_NO_COPY_CLASS(DatumSequenceEditorEvtHandler)
};
-IMPLEMENT_DYNAMIC_CLASS(DatumSequenceEditorEvtHandler, wxEvtHandler)
-
BEGIN_EVENT_TABLE(DatumSequenceEditorEvtHandler, wxEvtHandler)
EVT_CHAR(DatumSequenceEditorEvtHandler::UponChar)
EVT_KEY_DOWN(DatumSequenceEditorEvtHandler::UponKeyDown)
- [lmi-commits] [lmi] master updated (6977670 -> 713d56f), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 14ac975 03/46: Use at() instead of operator[] in non-performance-critical code, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 193e804 01/46: Refactor census view to enable several implementations, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c094807 05/46: Remove unnecessary altColor_ member variable, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3d86a92 06/46: Use simpler wxGrid::AssignTable(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c9e743f 08/46: Remove extra blank line from census_view.hpp, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequenceEditorEvtHandler,
Greg Chicares <=
- [lmi-commits] [lmi] master 5ee4b04 13/46: Improve comments in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 03d33ab 14/46: Make DatumSequenceEditorEvtHandler::entry_ const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 0e2a694 16/46: Replace DatumSequenceEditorEvtHandler with a lambda, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3e9f8af 02/46: Add census_view variant with wxGrid, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 25a989e 10/46: Make table_type_converter::get_all() map const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 12940dc 09/46: Define static map in more compact way, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master e1fdb77 12/46: Use Bind() in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7e048d0 15/46: Remove apparently unnecessary wxEVT_CHAR handler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::get_by_value() to just get(), Greg Chicares, 2020/07/22