|
From: | James Lowe |
Subject: | Re: [RFC] Enabling GitLab CI |
Date: | Sun, 17 May 2020 21:14:59 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 17/05/2020 20:27, Jonas Hahnfeld wrote:
- Comparison of regression tests is not yet integrated, the main problem being the need for a baseline. I already have an idea or two how this could work, but for now I'm focusing on the initial setup. This means James still needs to download the patches and run 'make check' (make doc being run automatically).
Yes that would save me time. Something that strikes me immediately.* If a CI run makes doc are we going to have an entry and or label in the comment for a success/failure?
I don't want to bother with any test if make/make doc fails, so I assume that it will change the label to take it off patch new. But at the same time if a patch is 'new' and hasn't had the make/make doc test, do I still run the make check anyway? If so then it passed the label would go to review and I assume the CI run would still catch that and do the make/make doc. Otherwise I am going to not only have to check for a patch 'new' I am going to have to know that it is waiting on a make doc first if you see what I mean? (will I have to second guess the CI so to speak)
Thanks. James
[Prev in Thread] | Current Thread | [Next in Thread] |